dalelane commented on code in PR #28831:
URL: https://github.com/apache/flink/pull/28831#discussion_r3711082544
##########
.github/workflows/nightly.yml:
##########
@@ -77,6 +109,163 @@ jobs:
s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY }}
s3_secret_key: ${{ secrets.IT_CASE_S3_SECRET_KEY }}
+ snapshot_binary:
+ name: "Snapshot Binary Release"
+ runs-on: ubuntu-24.04
+ container:
+ image: apache/flink-ci-docker:java_8_11_17_21_25_maven_386_jammy
+ options: --init --privileged
+ env:
+ MOUNTED_WORKING_DIR: /__w/flink/flink
+ CONTAINER_LOCAL_WORKING_DIR: /root/flink
+ MAVEN_REPO_FOLDER: /root/.m2/repository
+ MAVEN_ARGS: -Dmaven.repo.local=/root/.m2/repository
+ RELEASE_DIR: /root/flink/tools/releasing/release
+ steps:
+ - name: "Flink Checkout"
+ uses: actions/checkout@v7
+ with:
+ persist-credentials: false
+ - name: "Initialize job"
+ uses: "./.github/actions/job_init"
+ with:
+ jdk_version: 11
+ maven_repo_folder: ${{ env.MAVEN_REPO_FOLDER }}
+ source_directory: ${{ env.MOUNTED_WORKING_DIR }}
+ target_directory: ${{ env.CONTAINER_LOCAL_WORKING_DIR }}
+ - name: "Build snapshot binary release"
+ working-directory: ${{ env.CONTAINER_LOCAL_WORKING_DIR }}
+ shell: bash
+ run: |
+ # errexit needs to be disabled explicitly here because
maven-utils.sh handles the error if a mirror is not available
+ set +o errexit
+ source ./tools/ci/maven-utils.sh
+ set -o errexit
+ run_mvn -version
+ export MVN="run_mvn"
+ export RELEASE_VERSION=$(MVN_RUN_VERBOSE=false run_mvn help:evaluate
-Dexpression=project.version -q -DforceStdout)
+ echo "Determined RELEASE_VERSION as '$RELEASE_VERSION'"
+ cd tools
+ MVN_RUN_VERBOSE=true SKIP_GPG=true SKIP_PYTHON_WHEELS=true
./releasing/create_binary_release.sh
Review Comment:
[github actions fails fast by
default](https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#exit-codes-and-error-action-preference),
so I didn't think this was needed - but in hindsight, relying on a default
that could change is probably not ideal, and it is clearer to have it in the
script - so I did that in 336e9644a367763a98c74e9807ab3a3708c77647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
