yuxiqian commented on code in PR #4493:
URL: https://github.com/apache/flink-cdc/pull/4493#discussion_r3710058903


##########
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/CliFrontendOptions.java:
##########
@@ -52,8 +52,7 @@ public class CliFrontendOptions {
                     .hasArg()
                     .desc(
                             "The deployment target for the execution. This can 
take one of the following values "

Review Comment:
   Yes! It could also be constructed like this:
   
   ```java
       public static final ConfigOption<SchemaChangeBehavior> 
PIPELINE_SCHEMA_CHANGE_BEHAVIOR =
               ConfigOptions.key("schema.change.behavior")
                       .enumType(SchemaChangeBehavior.class)
                       .defaultValue(SchemaChangeBehavior.LENIENT)
                       .withDescription(
                               Description.builder()
                                       .text("Behavior for handling schema 
change events. ")
                                       .linebreak()
                                       .add(
                                               ListElement.list(
                                                       text("IGNORE: Drop all 
schema change events."),
                                                       text(
                                                               "LENIENT: Apply 
schema changes to downstream tolerantly, and keeps executing if applying 
fails."),
                                                       text(
                                                               "TRY_EVOLVE: 
Apply schema changes to downstream, but keeps executing if applying fails."),
                                                       text(
                                                               "EVOLVE: Apply 
schema changes to downstream. This requires sink to support handling schema 
changes."),
                                                       text(
                                                               "EXCEPTION: 
Throw an exception to terminate the sync pipeline.")))
                                       .build());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to