wenjin272 commented on PR #951: URL: https://github.com/apache/flink-agents/pull/951#issuecomment-5174319062
The Python path now cleans up repositories on every load/registration failure, but the Java `SkillManager.loadAll()` still catches only `IOException | IllegalArgumentException`. An unexpected `RuntimeException` or `Error` from `open()`, `originOf()`, or `registerRepo()` therefore still escapes without calling `closeRepos()`. I reproduced this with `repo.getSkills()` throwing `IllegalStateException`: neither the earlier repository nor the repository whose registration failed was closed. Could we add the equivalent Java cleanup path, preserve the original exception with cleanup failures suppressed, and cover it with a regression test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
