[
https://issues.apache.org/jira/browse/FLINK-40320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-40320:
-----------------------------------
Labels: pull-request-available (was: )
> CI: community review labeling counts the PR author's and co-authors' own
> reviews
> --------------------------------------------------------------------------------
>
> Key: FLINK-40320
> URL: https://issues.apache.org/jira/browse/FLINK-40320
> Project: Flink
> Issue Type: Bug
> Components: Build System / CI
> Reporter: Purushottam Sinha
> Priority: Minor
> Labels: pull-request-available
>
> Problem
>
>
> community-review.sh applies community-reviewed when a non-committer reviews a
> PR, but the tally includes reviews written by the people who wrote the PR. A
> PR can carry the label with no community review having happened.
>
>
>
>
>
>
> Evidence
>
>
> - GitHub blocks self-approval, but an author's comment on their own diff is
> still a PULL_REQUEST_REVIEW with state COMMENTED, which increments the tally
> for a non-committer author.
> - #28190 carries community-reviewed; its only reviews are two COMMENTED
> reviews by its own author.
>
> - A run over the 370 open PRs finds 21 author self-reviews being counted.
>
>
>
>
>
> Proposed fix
>
>
> - Exclude the author's own reviews.
>
>
> - Exclude co-authors, but only where their commit predates their first
> review — GitHub adds Co-authored-by when a suggestion is committed, so later
> co-authorship comes from the review itself (#28791,
> #28793).
>
>
> - Count a request for changes whoever it came from; a co-author can submit
> one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
