weiqingy opened a new pull request, #957:
URL: https://github.com/apache/flink-agents/pull/957

   Linked issue: #894
   
   ### Purpose of change
   
   Continues item 2 of #894 by filling the `Python-Java bridge` row that #911 
left as `planned`. #911 established the template and noted the remaining change 
types would follow one small PR each once the shape settled. This is the first 
of those.
   
   `review-guides/python-java-bridge.md` follows the merged 
`runtime-state-recovery.md` shape: a focused checklist that narrows the full 
passes in `code_review.md`, and two examples drawn from real review threads on 
merged PRs, each linking the specific comment.
   
   It adds one section the first guide does not have, a short `Validation` 
block naming both language lanes. The bridge is the change type where running 
one language's tests is most easily mistaken for running the tests, so the 
guide gives the narrowed Java and Python commands and says what they cover 
between them. If you would rather the guides stay uniform, I can drop it here 
or add the equivalent to the runtime guide.
   
   The checklist is six bullets, matching the sibling. Interpreter close 
ordering was left out deliberately. It is a real crash source, but the rarest 
trigger, since only PRs touching open and close reach it. Straightforward to 
add if you would like it covered.
   
   The other three rows stay `planned` and will follow the same way.
   
   ### Tests
   
   Not applicable, documentation only, no logic.
   
   `./tools/check-license.sh` passes with the change. No license header is 
needed, since `tools/.rat-excludes` already covers `review-guides/`.
   
   Every checklist claim was checked against source rather than written from 
memory, and both review permalinks were re-fetched with the cited PRs confirmed 
merged.
   
   The Java command was run. `mvn --batch-mode -pl runtime -am` resolves and 
runs the upstream module tests. The Python lane was verified by collection 
rather than by running `uv` itself, and it needed a correction: `uv sync 
--extra test` on its own is not enough, because 
`python/flink_agents/api/events/event.py` imports `pyflink.common.Row` at 
module level while `apache-flink` is declared in neither the `test` extra nor 
the base dependencies, so collection fails across all three directories without 
it. The guide points at `tools/ut.sh` for the supported version list rather 
than naming a version, so it does not drift at the next bump.
   
   ### API
   
   No. No code or public API change.
   
   ### Documentation
   
   - [x] `doc-included`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to