pltbkd commented on code in PR #938: URL: https://github.com/apache/flink-agents/pull/938#discussion_r3702566664
########## api/src/main/java/org/apache/flink/agents/api/subagent/Result.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.agents.api.subagent; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonIgnore; +import com.fasterxml.jackson.annotation.JsonProperty; + +import java.io.PrintWriter; +import java.io.Serializable; +import java.io.StringWriter; + +/** + * Outcome of a {@link Subagent} call. + * + * <p>Sub-agent implementations should capture internal failures into a {@code Result} (via {@link + * #error}) instead of throwing, so callers can inspect {@link #isSuccess()} without try/catch. + * + * <p>The failure cause is carried as a serializable {@code errorMessage} — the full stack trace of + * the failure — rather than a live exception, so that a {@code Result} can be persisted through + * durable execution. + */ +public class Result implements Serializable { + + private static final long serialVersionUID = 1L; + + private final boolean success; + private final Object result; Review Comment: Thanks for catching this — it's a real oversight. I'm currently working on the cross-language sub-agent invocation design and ran into the same issue there. The plan is to add `getResult(Class<T>)` backed by OBJECT_MAPPER.convertValue. This unifies all three paths where result can appear as a LinkedHashMap: durable recovery (Jackson JSON deserialization), cross-language sub-agent calls (pemja conversion), and first execution (direct cast, no conversion needed). convertValue handles the Map→POJO conversion uniformly regardless of the source. One known limitation: for generic collection payloads like List<Review>, both recovery and cross-language paths leave result as ArrayList<LinkedHashMap> — getResult(List.class) only returns List<LinkedHashMap>, losing element types. A `getResult(TypeReference<T>)` overload can be added later if type-safe collections are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
