weiqingy commented on PR #952: URL: https://github.com/apache/flink-agents/pull/952#issuecomment-5162320702
Hi @wenjin272 , could you take a look at this PR when you get a chance? A second sample for the Implementation Description experiment on #894, the Python refusal parity fix that came out of writing the #930 description. It is much smaller than #930, 123 lines across 4 files, so it may be an easier one to startwith if the Azure PR is a lot to get through. Two things changed in how it is written, both because #930's description turned out to be unreadable at 24k characters. The description is the PR body now rather than a separate comment. Four of the six fields you listed already have homes in the current template, so only behavioral contracts and failure behavior needed a new heading. The whole body is about 6k characters. The tests table maps one row per contract instead of one row per test, which is what made the #930 version long. I have not touched the PR template itself. That seemed worth holding until you have actually reviewed one of these and can say whether it makes the review easier or just adds reading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
