weiqingy commented on PR #28878: URL: https://github.com/apache/flink/pull/28878#issuecomment-5160766593
FLIP-485 passed the vote on 2026-08-01 with 3 binding +1 and no -1: https://lists.apache.org/thread/symqpswsohl2s5wmtkcw0jjp1w5dot0n This is the first of four PRs landing the accepted design. It replaces the single reference-implementation draft in #28692, which I'm closing. This PR adds only the `UdfMetrics` helper and its unit test. It has no caller yet on purpose. The first caller arrives in PR 2, which adds the two config options and instruments synchronous scalar and table UDF calls. Splitting it out keeps the sampling and registration logic reviewable on its own, since it is the piece both the sync and async paths share. The series: 1. `UdfMetrics` helper (this PR) 2. `table.exec.udf-metric-enabled` / `table.exec.udf-metric.sample-interval` plus synchronous scalar and table instrumentation 3. Asynchronous scalar and table instrumentation 4. Documentation Each PR builds and passes its own tests independently. I'll open the next one as the previous merges. @xuyangzhong @RocMarshal @HuangZhenQiu you all voted on the FLIP, so if you have time to take a look here I'd appreciate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
