[ 
https://issues.apache.org/jira/browse/FLINK-39505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101074#comment-18101074
 ] 

Bettle commented on FLINK-39505:
--------------------------------

Hi, I'd like to work on this issue.

My proposed approach is:
1. Identify the recently added Table methods that are missing Python-side 
coverage.
2. Add focused tests for argument forwarding, return wrappers, and error 
propagation.
3. Cover at least from_changelog, to_changelog, insert_into, and print_explain.
4. Run the relevant flink-python Table test suite.

Could a committer please confirm the scope and assign the issue to me?
Thanks!

> Add Python-side tests for recently added Table API methods
> ----------------------------------------------------------
>
>                 Key: FLINK-39505
>                 URL: https://issues.apache.org/jira/browse/FLINK-39505
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Python
>            Reporter: Ramin Gharib
>            Priority: Minor
>
> Several recently added pyflink.table.Table methods are missing PyFlink-side 
> test coverage. The Java implementations are exercised by Java tests, but the 
> Python wrappers in flink-python/pyflink/table/table.py (which delegate to the 
> Java side via py4j) are not directly tested. As a result, regressions in 
> argument marshalling, named-argument forwarding, or method signatures would 
> only be caught when a downstream user runs the Python API end-to-end.
> Affected methods (non-exhaustive):
>   - Table.from_changelog (added in FLINK-39479)
>   - Table.to_changelog
>   - Table.insert_into
>   - Table.print_explain
> A scan of pyflink/table/table.py may surface additional recently added 
> methods that fall in the same category.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to