snuyanzin commented on code in PR #28622:
URL: https://github.com/apache/flink/pull/28622#discussion_r3695571366
##########
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java:
##########
@@ -631,17 +633,17 @@ public String select(Map<String, List<Event>> pattern) {
List<String> timeoutExpected = Arrays.asList("1.0", "2.0");
List<String> resultExpected = Arrays.asList("1.0,2.0,2.0",
"2.0,2.0,2.0");
- assertEquals(timeoutExpected, timeoutList);
- assertEquals(resultExpected, resultList);
+ assertThat(timeoutList).containsExactlyElementsOf(timeoutExpected);
+ assertThat(resultList).containsExactlyElementsOf(resultExpected);
Review Comment:
why do we need object creation if they are used only in assertions?
Can we inline and just use `containsExactly`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
