gustavodemorais commented on code in PR #28815:
URL: https://github.com/apache/flink/pull/28815#discussion_r3667151078
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java:
##########
@@ -317,97 +316,89 @@ private static List<TestSetSpec> isJsonSpec() {
TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
.onFieldsWithData((String) null)
.andDataTypes(STRING())
- // IS [NOT] JSON follows SQL three-valued logic and
returns NULL for a NULL
- // input, see FLINK-39943. This holds for every JSON
type and for both the
- // IS JSON and IS NOT JSON forms.
- .testResult($("f0").isJson(), "f0 IS JSON", null,
BOOLEAN())
- .testResult($("f0").isJson().not(), "f0 IS NOT JSON",
null, BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.VALUE), "f0 IS JSON
VALUE", null, BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.VALUE).not(),
- "f0 IS NOT JSON VALUE",
- null,
- BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.SCALAR),
- "f0 IS JSON SCALAR",
- null,
- BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.SCALAR).not(),
- "f0 IS NOT JSON SCALAR",
- null,
- BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.ARRAY), "f0 IS JSON
ARRAY", null, BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.ARRAY).not(),
- "f0 IS NOT JSON ARRAY",
- null,
- BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.OBJECT),
- "f0 IS JSON OBJECT",
- null,
- BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.OBJECT).not(),
- "f0 IS NOT JSON OBJECT",
- null,
- BOOLEAN()),
+ .testResult($("f0").isJson(), "f0 IS JSON", false,
BOOLEAN().notNull()),
TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
.onFieldsWithData("a")
.andDataTypes(STRING())
- .testResult($("f0").isJson(), "f0 IS JSON", false,
BOOLEAN())
- .testResult($("f0").isJson().not(), "f0 IS NOT JSON",
true, BOOLEAN()),
- TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
- // A non-nullable input yields a non-nullable BOOLEAN
result.
- .onFieldsWithData("a")
- .andDataTypes(STRING().notNull())
.testResult($("f0").isJson(), "f0 IS JSON", false,
BOOLEAN().notNull()),
TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
.onFieldsWithData("\"a\"")
.andDataTypes(STRING())
- .testResult($("f0").isJson(), "f0 IS JSON", true,
BOOLEAN())
+ .testResult($("f0").isJson(), "f0 IS JSON", true,
BOOLEAN().notNull())
.testResult(
- $("f0").isJson(JsonType.VALUE), "f0 IS JSON
VALUE", true, BOOLEAN())
+ $("f0").isJson(JsonType.VALUE),
+ "f0 IS JSON VALUE",
+ true,
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.SCALAR),
"f0 IS JSON SCALAR",
true,
- BOOLEAN())
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.ARRAY),
"f0 IS JSON ARRAY",
false,
- BOOLEAN())
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.OBJECT),
"f0 IS JSON OBJECT",
false,
- BOOLEAN()),
+ BOOLEAN().notNull()),
TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
.onFieldsWithData("{}")
.andDataTypes(STRING())
- .testResult($("f0").isJson(), "f0 IS JSON", true,
BOOLEAN())
+ .testResult($("f0").isJson(), "f0 IS JSON", true,
BOOLEAN().notNull())
.testResult(
- $("f0").isJson(JsonType.VALUE), "f0 IS JSON
VALUE", true, BOOLEAN())
+ $("f0").isJson(JsonType.VALUE),
+ "f0 IS JSON VALUE",
+ true,
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.SCALAR),
"f0 IS JSON SCALAR",
false,
- BOOLEAN())
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.ARRAY),
"f0 IS JSON ARRAY",
false,
- BOOLEAN())
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.OBJECT),
"f0 IS JSON OBJECT",
true,
- BOOLEAN()));
+ BOOLEAN().notNull()),
+ TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
Review Comment:
Since the same mapper now affects every JSON function, could we add a
trailing-garbage case for JSON_VALUE/JSON_QUERY/JSON_EXISTS as well (e.g.
{"a":1} x)? Right now a future revert of the flag would only fail the IS JSON
specs
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java:
##########
@@ -317,97 +316,89 @@ private static List<TestSetSpec> isJsonSpec() {
TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
.onFieldsWithData((String) null)
.andDataTypes(STRING())
- // IS [NOT] JSON follows SQL three-valued logic and
returns NULL for a NULL
- // input, see FLINK-39943. This holds for every JSON
type and for both the
- // IS JSON and IS NOT JSON forms.
- .testResult($("f0").isJson(), "f0 IS JSON", null,
BOOLEAN())
- .testResult($("f0").isJson().not(), "f0 IS NOT JSON",
null, BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.VALUE), "f0 IS JSON
VALUE", null, BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.VALUE).not(),
- "f0 IS NOT JSON VALUE",
- null,
- BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.SCALAR),
- "f0 IS JSON SCALAR",
- null,
- BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.SCALAR).not(),
- "f0 IS NOT JSON SCALAR",
- null,
- BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.ARRAY), "f0 IS JSON
ARRAY", null, BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.ARRAY).not(),
- "f0 IS NOT JSON ARRAY",
- null,
- BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.OBJECT),
- "f0 IS JSON OBJECT",
- null,
- BOOLEAN())
- .testResult(
- $("f0").isJson(JsonType.OBJECT).not(),
- "f0 IS NOT JSON OBJECT",
- null,
- BOOLEAN()),
+ .testResult($("f0").isJson(), "f0 IS JSON", false,
BOOLEAN().notNull()),
TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
.onFieldsWithData("a")
.andDataTypes(STRING())
- .testResult($("f0").isJson(), "f0 IS JSON", false,
BOOLEAN())
- .testResult($("f0").isJson().not(), "f0 IS NOT JSON",
true, BOOLEAN()),
- TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
- // A non-nullable input yields a non-nullable BOOLEAN
result.
- .onFieldsWithData("a")
- .andDataTypes(STRING().notNull())
.testResult($("f0").isJson(), "f0 IS JSON", false,
BOOLEAN().notNull()),
TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
.onFieldsWithData("\"a\"")
.andDataTypes(STRING())
- .testResult($("f0").isJson(), "f0 IS JSON", true,
BOOLEAN())
+ .testResult($("f0").isJson(), "f0 IS JSON", true,
BOOLEAN().notNull())
.testResult(
- $("f0").isJson(JsonType.VALUE), "f0 IS JSON
VALUE", true, BOOLEAN())
+ $("f0").isJson(JsonType.VALUE),
+ "f0 IS JSON VALUE",
+ true,
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.SCALAR),
"f0 IS JSON SCALAR",
true,
- BOOLEAN())
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.ARRAY),
"f0 IS JSON ARRAY",
false,
- BOOLEAN())
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.OBJECT),
"f0 IS JSON OBJECT",
false,
- BOOLEAN()),
+ BOOLEAN().notNull()),
TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
.onFieldsWithData("{}")
.andDataTypes(STRING())
- .testResult($("f0").isJson(), "f0 IS JSON", true,
BOOLEAN())
+ .testResult($("f0").isJson(), "f0 IS JSON", true,
BOOLEAN().notNull())
.testResult(
- $("f0").isJson(JsonType.VALUE), "f0 IS JSON
VALUE", true, BOOLEAN())
+ $("f0").isJson(JsonType.VALUE),
+ "f0 IS JSON VALUE",
+ true,
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.SCALAR),
"f0 IS JSON SCALAR",
false,
- BOOLEAN())
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.ARRAY),
"f0 IS JSON ARRAY",
false,
- BOOLEAN())
+ BOOLEAN().notNull())
.testResult(
$("f0").isJson(JsonType.OBJECT),
"f0 IS JSON OBJECT",
true,
- BOOLEAN()));
+ BOOLEAN().notNull()),
+ TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
Review Comment:
You have multiple TestSetSpec, but you could group them under one single
TestSetSpec as the tests above do
```suggestion
TestSetSpec.forFunction(BuiltInFunctionDefinitions.IS_JSON)
.onFieldsWithData("{} dsfsd", "true randomGarbage", "null,
randomGarbage")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
