Timm0 commented on code in PR #28828:
URL: https://github.com/apache/flink/pull/28828#discussion_r3664205044
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/ValueDataTypeConverter.java:
##########
@@ -217,7 +217,7 @@ private static int fractionalSecondPrecision(int nanos) {
return String.format("%09d", nanos).replaceAll("0+$", "").length();
}
- private static int yearPrecision(int years) {
+ private static int yearPrecision(long years) {
return String.valueOf(years).length();
Review Comment:
Good point, it's actually the same for `days` as well. I'll fix it in the
scope of this PR as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
