rosemarYuan commented on code in PR #923:
URL: https://github.com/apache/flink-agents/pull/923#discussion_r3663097832
##########
api/src/main/java/org/apache/flink/agents/api/Event.java:
##########
@@ -81,6 +87,30 @@ public Map<String, Object> getAttributes() {
return attributes;
}
+ /** Returns the ID of the Event consumed by the Action that emitted this
Event. */
+ @Nullable
+ @JsonInclude(JsonInclude.Include.NON_NULL)
+ public UUID getUpstreamEventId() {
+ return upstreamEventId;
+ }
+
+ /** Sets the ID of the Event consumed by the Action that emitted this
Event. */
+ public void setUpstreamEventId(@Nullable UUID upstreamEventId) {
Review Comment:
Thanks @joeyutong and @weiqingy for the careful reviews. I’ve addressed the
feedback locally in three latest commits. The replay behavior is now documented
and tested. A reused output Event keeps its ID, but its lineage is updated to
the current trigger. For Event reconstruction, custom Events in Java now use`
Event.reconstructFrom(source, factory)`, while custom Events in Python
use`reconstruct_from(source)`. These helpers preserve the Event ID and lineage.
The Trace Tree reader accepts the same Event ID with different valid parent
links when its type and content remain unchanged. A separate test checks the
exact Event IDs and lineage before and after replay. I also made the Trace Tree
reader available from the installed Python package, improved malformed log
handling, and added the related tests.
Thanks again for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
