1996fanrui commented on PR #28305: URL: https://github.com/apache/flink/pull/28305#issuecomment-5091060945
Thanks @pltbkd for the comments! > This preserves the ability to distinguish "downstream is the bottleneck" from "operator's internal processing is the bottleneck" for dashboard-based diagnosis. WDYT? Sounds good to me, it ensures both semantics are correct. > Also, since the approach now retains `recordWriter` for classification (not direct replacement), `SupportsOutputAvailability` might not fit well. Would `SupportsChainAvailability` work better, or should we keep the current `SupportsSoftBackpressure` naming? I prefer `SupportsChainAvailability`, wdyt? > Without network exchange, there is a small regression (2–4%), because the patch adds a new check on a path that previously had none. However, this is consistent with the overhead introduced when the soft backpressure mechanism was originally added — this patch just extends its coverage to this scene. It seems expected that this kind of regression would appear after introducing the check. I am curious why it is so obvious? Generally, the check should be very light. quick question: this check chain doesn't have too many nested layers, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
