auroflow commented on code in PR #28797: URL: https://github.com/apache/flink/pull/28797#discussion_r3652203598
########## flink-python/pyflink/dataframe/convert.py: ########## @@ -0,0 +1,263 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +from enum import Enum +from typing import Any, Iterable, List, Mapping, Optional, Sequence, Tuple, Union, cast + +from pyflink.dataframe.context import get_or_create_table_environment +from pyflink.dataframe.dataframe import DataFrame +from pyflink.util.api_stability_decorators import PublicEvolving + +__all__ = ["from_dict", "from_records"] + +_SCALAR_SEQUENCE_TYPES = (str, bytes, bytearray, memoryview) + + +class _RecordType(Enum): + NAMED_TUPLE = "named_tuple" + MAPPING = "mapping" + SEQUENCE = "sequence" + + @classmethod + def from_record(cls, record: Any) -> "_RecordType": + if isinstance(record, tuple) and isinstance( + getattr(record, "_fields", None), tuple + ): + return cls.NAMED_TUPLE + if isinstance(record, Mapping): + return cls.MAPPING + if isinstance(record, Sequence) and not isinstance( + record, _SCALAR_SEQUENCE_TYPES + ): + return cls.SEQUENCE + raise TypeError + + +def _validate_schema(schema: List[str]) -> None: + if not isinstance(schema, list) or any(not isinstance(name, str) for name in schema): + raise TypeError("schema must be a list of strings") + if not schema: + raise ValueError("schema must not be empty") + if any(not name for name in schema): + raise ValueError("schema field names must not be empty") + if len(set(schema)) != len(schema): + raise ValueError("schema field names must be unique") + + +def _validate_record_type( Review Comment: Agreed. In my opinion we can move `_to_field_mapping` under `_RecordType` too. I changed `_to_field_mapping` to `_RecordType.normalize_record`, which normalizes all three types of records to tuples, so `from_records` has a single path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
