weiqingy commented on code in PR #921:
URL: https://github.com/apache/flink-agents/pull/921#discussion_r3633439293
##########
python/flink_agents/plan/actions/action.py:
##########
@@ -95,11 +95,11 @@ def __custom_deserialize(self) -> "Action":
self["config"][name] = value["value"]
return self
for name, value in config.items():
- try:
+ if isinstance(value, list | tuple):
Review Comment:
Thanks for digging into this. Good catch that `add_action(**config)` already
makes a plain list reachable today, so this was live, not just future. The
marker approach looks right, and the new `preserves_plain_list` test locks the
contract in.
I also checked the compatibility point you raised: `deserializePythonConfig`
on the java side is a generic recursive passthrough, so it never interprets the
old tuple or the new marker. The marker dict round-trips the same as before, no
java change needed. Your read holds.
Nothing further from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
