bigdataMS commented on PR #4246: URL: https://github.com/apache/flink-cdc/pull/4246#issuecomment-4965149278
Hi @ThorneANN, thanks for the great work on this feature — it addresses a real gap for DataStream users who need to add tables to a long-running job **without** a snapshot phase (the same use case @J9527H described above, and one we hit in production too). Since the PR has been idle for a few months, would you be OK with me helping push it forward? I'd rebase onto the latest master to get CI green and address the outstanding review feedback. Of course I'll keep your authorship via `Co-authored-by` and credit this as the original work. @yuxiqian @lvyanquan — if that's acceptable, my plan would be: 1. Rebase on master, fix CI. 2. Address @yuxiqian's point on regex semantics: drop the custom `.`/`\.` remapping and keep binlog-capture mode consistent with the connector's standard pattern semantics (this also removes the need to rewrite `TableIdRouter#convertTableListToRegExpPattern`). 3. Add the missing stream-only startup-mode validation for `scan.binlog.newly-added-table.enabled`. 4. Remove the redundant mutual-exclusion check in `MySqlSnapshotSplitAssigner` and fix the doc regex examples. 5. Validate end-to-end on a real DataStream pipeline (@J9527H kindly offered to help test). Happy to do this as a new PR that supersedes #4246, or by pushing to @ThorneANN's branch if preferred — whichever the maintainers think is cleaner. Please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
