MartijnVisser commented on PR #27745: URL: https://github.com/apache/flink/pull/27745#issuecomment-4916313875
Thanks for the thorough turnaround @gkomlossi, and for the manual test call-outs. I went through it, it looks good overall. I think the NOTICE is complete and correct. The (MPL-2.0 OR Apache-2.0) on dompurify is fine; we would choose Apache-2.0, no separate LICENSE entry needed (same as the recent d3-flame-graph bump in #28601, which was NOTICE-only). One small thing before I can approve: the regenerated NOTICE introduced CRLF line endings in the [email protected] and [email protected] blocks (the rest of the file, including your new entries, is LF). generate_notice.sh does this occasionally. Could you normalize those back to LF and repush? Once that's in I'll get this merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
