weiqingy commented on code in PR #880:
URL: https://github.com/apache/flink-agents/pull/880#discussion_r3540383941
##########
runtime/src/test/java/org/apache/flink/agents/runtime/operator/ActionExecutionOperatorTest.java:
##########
@@ -1711,6 +1732,16 @@ public static void durableMixedRecoveryAction(Event
event, RunnerContext context
}
}
+ public static class LinkageErrorAction {
+ static {
+ if (System.nanoTime() >= 0) {
Review Comment:
Could we make this linkage-error fixture deterministic? `System.nanoTime()`
is permitted to return a negative value, so on a JVM where that happens the
static initializer would complete normally and this regression test would fail
for environmental reasons instead of exercising the intended
`Error`-propagation path. A deterministic guard like `if (true)` (or an
`alwaysTrue()` helper) keeps the fixture focused on the `LinkageError` path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
