lnbest0707 opened a new pull request, #283:
URL: https://github.com/apache/flink-connector-kafka/pull/283

   ## What is the purpose of the change
   
   This implements 
[FLINK-40094](https://issues.apache.org/jira/browse/FLINK-40094) as the 
mandatory correctness follow-up to 
[FLINK-39979](https://issues.apache.org/jira/browse/FLINK-39979) and 
[#276](https://github.com/apache/flink-connector-kafka/pull/276).
   
   #276 correctly marks the `DynamicKafkaSource` reader's main output idle when 
metadata removal leaves a source subtask without active subreaders. Flink also 
maintains split-local outputs for source watermark aggregation, however, and 
directly calling `releaseOutputForSplit` does not recompute or publish their 
aggregate watermark/idleness. A removed split that was active can therefore 
leave the subtask output active and pin the downstream watermark even after the 
main reader output becomes idle.
   
   This change marks each removed split output idle immediately before 
releasing it. That forces Flink to publish the updated aggregate state before 
the split-local output is unregistered.
   
   ## Brief change log
   
   - Mark removed split outputs idle before both immediate and deferred release.
   - Add no-Docker regression coverage for both paths, including the required 
`idle` then `release` ordering.
   
   ## Verifying this change
   
   - `mvn -pl flink-connector-kafka -Dtest=DynamicKafkaSourceReaderIdlenessTest 
-DskipITs -Drat.skip=true test`
   - `mvn -pl flink-connector-kafka -Drat.skip=true clean test`
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): no
   - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
   - The S3 file system connector: no
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes (OpenAI Codex)
   
   Generated-by: OpenAI Codex
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to