fqshopify opened a new pull request, #1154: URL: https://github.com/apache/flink-kubernetes-operator/pull/1154
## What is the purpose of the change This pull request removes an unnecessary extra reconciliation loop during `FlinkBlueGreenDeployment` cutover. Previously, after the operator successfully deleted the previous `FlinkDeployment`, it returned `noUpdate().rescheduleAfter(RETRY_DELAY_MS)`. The BlueGreen deployment was only finalized in a later reconciliation after the controller observed that the previous deployment was gone. Once the previous deployment has been successfully deleted, the transition can be finalized immediately. This change reuses the existing `finalizeBlueGreenDeployment` logic in the same reconciliation that deletes the previous deployment, while preserving the retry behavior when deletion is not acknowledged. ## Brief change log - Pass the target `FlinkBlueGreenDeploymentState` into `deleteDeployment`. - Finalize the BlueGreen transition immediately after successful deletion of the previous `FlinkDeployment`. - Preserve the existing retry behavior when deletion fails or is not acknowledged. - Add a regression test verifying that the transition commits to `ACTIVE_GREEN` in the same reconciliation that deletes Blue. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no - Core observer or reconciler logic that is regularly executed: yes ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
