Savonitar commented on code in PR #28639:
URL: https://github.com/apache/flink/pull/28639#discussion_r3536804668
##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DelegationTokenManager.java:
##########
@@ -61,4 +63,37 @@ interface Listener {
/** Stops re-occurring token obtain task. */
void stop();
+
+ /**
+ * Requests an immediate, asynchronous token-obtain-and-distribute cycle,
bringing the next
+ * cycle forward instead of waiting for the periodic renewal. May be
called from any thread;
+ * it is a no-op on a manager constructed without executors (the one-shot
obtain path).
+ * Concurrent requests are coalesced and a configurable cooldown may
apply, so a call does
+ * not necessarily map to exactly one obtain.
+ *
+ * <p>Backs {@link
+ *
org.apache.flink.core.security.token.DelegationTokenManagerCallback#reobtainDelegationTokens()}.
+ */
+ default void reobtainDelegationTokens() {}
Review Comment:
Do you suggest to drop default bodies and make all 3 (registerJob,
unregisterJob, reobtainDelegationTokens) are abstract on the interface?
CONS:
1. Downstream forks with custom managers break at compile.
2. Will it create a precedent to going abstract instead of default which
will repeat ^ (breaking compilation) in the future again?
3. Asymmetry with the provider SPI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
