weiqingy commented on issue #829: URL: https://github.com/apache/flink-agents/issues/829#issuecomment-4898699616
Thanks @wenjin272 — agreed, and I'll take it forward. In beta the maintenance cost outweighs a second non-production path, and MiniCluster is the more faithful "validate without deploying" story. Two scope notes before I start. **`LocalMemoryObject`**: two tests use it purely as a plain in-memory `MemoryObject` fixture, unrelated to the runner — `plan/tests/actions/test_chat_model_action.py` and `runtime/tests/test_memory_reference.py`. Remove it outright and rewrite those, or keep it as a trimmed test fixture? Either's fine — just want to scope the PR right. **The test migration is a rewrite, not a lift-and-shift**: the local tests drive I/O through `from_list` / `to_list` and the local-only `get_tool_request_events()` hook, none of which have a MiniCluster equivalent (`RemoteExecutionEnvironment` raises `NotImplementedError` for both, `remote_execution_environment.py:170,280`). So those tests get re-expressed against a MiniCluster harness, not moved. Plan: (1) MiniCluster harness + migrate the runner tests, (2) delete `local_runner` / `local_execution_environment`, migrate the example, strip docs — folded into one PR if the migration is small, split if large. `LocalMemoryObject` lands separately per your answer. Let me know if you have any concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
