MartijnVisser commented on PR #28601: URL: https://github.com/apache/flink/pull/28601#issuecomment-4896105992
On the rest of the PR: I additionally verified the NOTICE independently (regenerated via dev/generate_notice.sh and cross-checked all 90 entries against the production dependency closure; everything matches and all licenses are Category A), so with the proxy fix and a green CI this is ready to merge. Optional nit while you're in there: FlamegraphNode.data.value should be number, not string (JobFlameGraphNode.value is a number). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
