1996fanrui opened a new pull request, #28659: URL: https://github.com/apache/flink/pull/28659
This PR depends on https://github.com/apache/flink/pull/28651 and https://github.com/apache/flink/pull/28652 Please only review the last 3 commits (prefixed [FLINK-39522]). ## What is the purpose of the change [FLINK-39522] Rework StreamTask recovery: async future chain, consume only after filtering completes. It's part 3 of FLINK-38544 (checkpointing during recovery of unaligned checkpoint state). StreamTask channel-state recovery is restructured into an asynchronous future chain on the channelIOExecutor, and recovery completion is unified on the gates' state-consumed futures. With checkpointing-during-recovery enabled, the task now consumes recovered state only after rescale filtering has fully completed (previously consumption overlapped with filtering); the filtered buffers are held in the recovered channels' memory queues and handed to the physical channels through the push interface at conversion. The now-unused filtering-progress gate API is removed. Non-CDR observable behavior is preserved; the defer-finish commit fixes an existing race where a finite task could finish before recovery completed. Checkpoints during recovery are declined at this stage. ## Brief change log - [FLINK-39522] Restructure StreamTask channel-state recovery into an async future chain - [FLINK-39522][network] Remove recovery flags and the filtering-complete future from the gate API - [FLINK-39522] Defer task finish until recovery completes ## Verifying this change - Existing and adapted tests: TaskCheckpointingBehaviourTest, StreamTaskTest, MultipleInputStreamTaskTest, SingleInputGateTest, UnionInputGateTest, RecoveredInputChannelTest, SequentialChannelStateReaderImplTest ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
