yuxiqian commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3524860807
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MysqlToKafkaE2eITCase.java:
##########
@@ -347,6 +352,28 @@ public void
testSyncWholeDatabaseWithDebeziumJsonHasSchema() throws Exception {
.containsExactlyInAnyOrderElementsOf(deserializeValues(collectedRecords));
}
+ private void waitUntilStreamSplitReady(JobID jobId, int parallelism)
throws Exception {
Review Comment:
Could be moved to `PipelineTestEnvironment` base class?
##########
.github/workflows/flink_cdc_base.yml:
##########
@@ -99,15 +99,15 @@ jobs:
modules=$(./.github/workflows/modules.py test "${{ matrix.module }}")
compile_modules=$(./.github/workflows/modules.py compile "${{
matrix.module }}")
-
+
build_maven_parameter="-DspecifiedMongoVersion=8.0.14"
if [ ! -z "${{ matrix.flink-version }}" ]; then
build_maven_parameter="${build_maven_parameter:+$build_maven_parameter
}-DspecifiedFlinkVersion=${{ matrix.flink-version }}"
fi
-
+
build_maven_parameter="${build_maven_parameter:+$build_maven_parameter }${{
inputs.custom-maven-parameter }}"
-
+
Review Comment:
Accidental changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
