gustavodemorais commented on code in PR #28585: URL: https://github.com/apache/flink/pull/28585#discussion_r3498441521
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/connectors/CollectResultProviderITCase.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.connectors; + +import org.apache.flink.table.api.EnvironmentSettings; +import org.apache.flink.table.api.TableEnvironment; +import org.apache.flink.table.api.TableResult; +import org.apache.flink.types.Row; +import org.apache.flink.util.CloseableIterator; +import org.apache.flink.util.CollectionUtil; + +import org.junit.jupiter.api.Test; + +import java.util.concurrent.TimeUnit; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatCode; + +/** + * ITCase for collecting SELECT results via the Table API (backed by {@code + * CollectDynamicSink.CollectResultProvider}). + */ +class CollectResultProviderITCase { + + @Test + void awaitAndCollectCompleteForEmptyBatchResult() throws Exception { Review Comment: Does it make sense to add one streaming test case with bounded source? ########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/CollectDynamicSink.java: ########## @@ -217,9 +217,14 @@ public RowDataToStringConverter getRowDataStringConverter() { @Override public boolean isFirstRowReady() { Review Comment: The Javadoc in ResultProvider.java says "the first row is ready when hasNext() returns true or next() returns a row" - but the fix now returns true even when hasNext() returned false (empty, finished job). Not if the users has to know this detail/if it's worth updating it over there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
