purushah commented on code in PR #852: URL: https://github.com/apache/flink-agents/pull/852#discussion_r3494554119
########## api/src/main/java/org/apache/flink/agents/api/chat/model/routing/RoutingCandidate.java: ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.agents.api.chat.model.routing; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Objects; + +/** + * A routable target of a {@link ChatModelRouter}. + * + * <p>A candidate names a chat-model setup that was registered as a {@link + * org.apache.flink.agents.api.resource.ResourceType#CHAT_MODEL} resource, together with an optional + * human-readable {@code description} (consumed by LLM-as-router strategies to reason about which + * model fits a request) and free-form {@code metadata} (e.g. {@code cost}, {@code tags}, + * capabilities) that rule-based or custom strategies can match against. + */ +public class RoutingCandidate { + + private final String name; + private final String description; + private final Map<String, Object> metadata; + + public RoutingCandidate(String name, String description, Map<String, Object> metadata) { + this.name = Objects.requireNonNull(name, "candidate name must not be null"); Review Comment: Added RoutingCandidateTest covering null, empty, and valid names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
