autophagy opened a new pull request, #28574:
URL: https://github.com/apache/flink/pull/28574
## What is the purpose of the change
While validating the behaviour of the PTF test harness against the tests
defined in `ProcessTableFunctionTestPrograms`, I found that the harness was
incorrectly handling instances where, inside a PTF, the user calls
`ctx.clearState()` to clear the state.
This caused the harness to write back a `null` value to the underlying state
handler, which would then be passed into the PTF and cause a npe within the PTF
which expects a non-null state. The tests didn't surface this because I had
added a defensive null check for the state within the context state clearing
PTF 🤦♀️
This PR instead maps to the behaviour of live by writing a freshly created
instance of the state to backing state store when the state is cleared, rather
than a null.
## Brief change log
- Fixed bug in ProcessTableFunctionTestHarness when clearing state using
`ctx.clearState`
## Verifying this change
This change is already covered by existing tests, such as
`testContextClearState` and `testContextClearAllState` in
`ProcessTableFunctionTestHarnessTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
