[ 
https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838448#comment-15838448
 ] 

ASF GitHub Bot commented on FLINK-5092:
---------------------------------------

Github user BorisOsipov commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2836#discussion_r97863068
  
    --- Diff: flink-contrib/flink-storm-examples/pom.xml ---
    @@ -364,6 +363,18 @@ under the License.
                                                        </transformers>
                                                </configuration>
                                        </execution>
    +                                   <execution>
    +                                           <id>shade-flink</id>
    --- End diff --
    
    The maven's philosophy is 'one artifact per project'. These projects don't 
follow this way and produces several jar's artifacts :)
    Shade plugin should produce 
flink-storm-streaming_2.10-1.2-SNAPSHOT-shaded.jar but it doesn't do it. It is 
a problem for maven install plugin that wants to have such jar by default. And 
it leads to failure on install phase without such configuration changes. For 
this reason I added such changes.
    
    So I propose don't collect test coverage for these projects (flink-storm 
and streaming examples)  at all. What do you think?


> Add integration with Sonarqube and code coverage
> ------------------------------------------------
>
>                 Key: FLINK-5092
>                 URL: https://issues.apache.org/jira/browse/FLINK-5092
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Boris Osipov
>            Assignee: Boris Osipov
>
> It would be good to have the opportunity to generate test coverage reports 
> for Flink and analyze code by SonarQube.
> Parts of tasks:
> - add generate test coverage reports for Flink with new maven profile
> - implement integration with https://analysis.apache.org/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to