raminqaf commented on code in PR #28403:
URL: https://github.com/apache/flink/pull/28403#discussion_r3413455699
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/stream/sql/ProcessTableFunctionTest.java:
##########
@@ -513,6 +517,11 @@ private static Stream<ErrorSpec> errorSpecs() {
"SELECT * FROM f(r => TABLE t_watermarked PARTITION BY
name, on_time => DESCRIPTOR(ts))",
Review Comment:
Good catch. The OVER case did reach the new message, but at a non-sink root
where both displayed nodes had the same mode. So it read as a mismatch with
nothing mismatched.
Updated the if statement so it fires on the root being the sink.
Intermediate-operator conflicts now fall back to the old path showing the full
plan.
Added two tests: a buried conflict under a Calc (sink boundary, friendly
message) and your OVER case (now the plan-dump fallback).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
