davidradl commented on code in PR #28441:
URL: https://github.com/apache/flink/pull/28441#discussion_r3412641410
##########
flink-python/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java:
##########
@@ -712,13 +719,42 @@ private int unref() {
Preconditions.checkState(refCount >= 0, "Reference count must not
be negative.");
if (refCount == 0) {
// Close environment after it was removed from cache and all
bundles finished.
- LOG.info("Closing environment {}",
environment.getEnvironment());
Review Comment:
fyi the approach we took in the HTTP connector is
[here](https://github.com/apache/flink-connector-http/blob/main/docs/content/docs/connectors/table/http.md#logging-the-http-content).
The way we thought about this was there are 2 use cases , debugging and
production. So we added a configuration option to define different levels of
logging that would effect encrypting. So there is an implementation choice
allowing debugging to occur outside production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
