Ryan-Nightwish commented on PR #830: URL: https://github.com/apache/flink-agents/pull/830#issuecomment-4706662181
Hi @xintongsong , based on your suggestion and without changing anything required by previous reviewers, I've made the following updates: - **Switched to a broadcast event model for parallel dispatch.** Replace fan-out loop in `request_aspect_judgments` with a single `SentimentInputEvent` dispatch as an intermediate broadcast: `request_aspect_judgments` emits just one event, and each aspect handler independently subscribes to it and issues its own `ChatRequestEvent`. - **Removed the `price` dimension.** Two parallel branches (taste + service) are sufficient to demonstrate the pattern, and the shorter example is easier to follow. - **Added event flow comments** to the `ParallelChatAgent` class docstring (Python) and Javadoc (Java) for at-a-glance understanding of the parallel topology. - **Updated `parallel_llm.md`** accordingly: Overview description, Create the Agent code snippets, and the Constraints hint. Please take a look — happy to adjust if there's anything else you'd like changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
