Copilot commented on code in PR #4436:
URL: https://github.com/apache/flink-cdc/pull/4436#discussion_r3410765955
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-postgres/src/main/java/org/apache/flink/cdc/connectors/postgres/source/PostgresDataSourceOptions.java:
##########
@@ -281,4 +281,17 @@ public class PostgresDataSourceOptions {
.defaultValue(false)
.withDescription(
"Whether to infer CDC column types when processing
pgoutput Relation messages.");
+
+ @Experimental
+ public static final ConfigOption<Boolean> SCAN_NEWLY_ADDED_TABLE_ENABLED =
Review Comment:
`SCAN_NEWLY_ADDED_TABLE_ENABLED` is annotated as `@Experimental`, but the
same option is already exposed and non-experimental in the MySQL pipeline
connector. Keeping it experimental may prevent it from being surfaced in
generated option docs, which undermines the goal of “exposing” the YAML option.
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-postgres/src/main/java/org/apache/flink/cdc/connectors/postgres/factory/PostgresDataSourceFactory.java:
##########
@@ -133,6 +134,7 @@ public DataSource createDataSource(Context context) {
int lsnCommitCheckpointsDelay =
config.get(SCAN_LSN_COMMIT_CHECKPOINTS_DELAY);
boolean tableIdIncludeDatabase = config.get(TABLE_ID_INCLUDE_DATABASE);
boolean includeSchemaChanges = config.get(SCHEMA_CHANGE_ENABLED);
+ boolean scanNewlyAddedTableEnabled =
config.get(SCAN_NEWLY_ADDED_TABLE_ENABLED);
Review Comment:
This new option wiring isn’t covered by existing factory tests. Consider
extending `PostgresDataSourceFactoryTest` to set
`scan.newly-added-table.enabled=true` and assert the created
`PostgresSourceConfig` has `isScanNewlyAddedTableEnabled()` enabled, to prevent
regressions in YAML-to-builder mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
