snuyanzin commented on code in PR #27026:
URL: https://github.com/apache/flink/pull/27026#discussion_r3410159773
##########
flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/token/S3HadoopDelegationTokenProvider.java:
##########
@@ -19,13 +19,18 @@
package org.apache.flink.fs.s3hadoop.token;
import org.apache.flink.annotation.Internal;
-import org.apache.flink.fs.s3.common.token.AbstractS3DelegationTokenProvider;
+import org.apache.flink.fs.s3.common.token.HadoopS3DelegationTokenProvider;
-/** Delegation token provider for S3 Hadoop filesystems. */
+/** Delegation token provider for S3 Hadoop filesystems using AWS SDK v2. */
@Internal
-public class S3HadoopDelegationTokenProvider extends
AbstractS3DelegationTokenProvider {
+public class S3HadoopDelegationTokenProvider extends
HadoopS3DelegationTokenProvider {
@Override
public String serviceName() {
return "s3-hadoop";
}
+
+ @Override
+ public String serviceConfigPrefix() {
+ return "security.delegation.token.provider.s3-hadoop";
Review Comment:
why do we need it hardcoded?
can we have something like
```java
DelegationTokenProvider.CONFIG_PREFIX + serviceName()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
