AlexYinHan commented on code in PR #28295:
URL: https://github.com/apache/flink/pull/28295#discussion_r3380252468
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##########
@@ -37,30 +38,31 @@ public class SavepointRestoreSettings implements
Serializable {
/** No restore should happen. */
private static final SavepointRestoreSettings NONE =
- new SavepointRestoreSettings(null, false,
RecoveryClaimMode.NO_CLAIM);
+ new SavepointRestoreSettings(null, null, null);
/** Savepoint restore path. */
- private final String restorePath;
+ private final @Nullable String restorePath;
/**
* Flag indicating whether non restored state is allowed if the savepoint
contains state for an
* operator that is not part of the job.
*/
- private final boolean allowNonRestoredState;
+ private final @Nullable Boolean allowNonRestoredState;
Review Comment:
Thanks for pointing it out. I forgot to consider the serialization problem
here. I keep the primitive ```boolean``` field and add a
```allowNonRestoredStateExplicitlySet``` to track it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
