luanxu-dev commented on issue #770: URL: https://github.com/apache/flink-agents/issues/770#issuecomment-4628389394
This looks like a good case for a compatibility fix plus a guard against silent fallback. I’d make the Java side prefer the documented `timeout` key, keep temporary support for the legacy `timeoutSeconds` key, and emit a deprecation warning when only `timeoutSeconds` is used. If both keys are present, `timeout` should probably win explicitly. The regression tests I’d add are: only `timeout` returns the custom value; only `timeoutSeconds` still works but warns; and both keys together do not silently fall back to the 30s default. That would keep Java/Python behavior aligned and make MCP tool timeouts less likely to be misdiagnosed as remote service instability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
