jubins commented on PR #264: URL: https://github.com/apache/flink-connector-kafka/pull/264#issuecomment-4627855450
> Hey @jubins thanks for you interest for the issue I created recently. When I called out the issue and created the Jira ticket, I got the proposal hence pushed this PR fix. > > IIUC, your PR looks like a start point as a framework, while this one is a concrete e2e implementations to cover real usage and some edge cases as well. As a result, would it make more sense to choose this PR as a follow up, thanks. hi @lnbest0707 Does your PR also include the framework-level changes from apache/flink#28318, or does it only contain connector-specific changes? Looking at your implementation, I see it's focused on the Kafka connector side. However, the framework classes (SplitAssignmentTracker, SourceCoordinatorSerdeUtils) live in the main Flink repository -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
