weiqingy commented on code in PR #745: URL: https://github.com/apache/flink-agents/pull/745#discussion_r3350419657
########## docs/content/docs/faq/faq.md: ########## @@ -81,25 +81,24 @@ Async execution can significantly improve performance by allowing multiple opera | Java (JDK 21+) | ✅ Supported (via Continuation API) | | Java (JDK < 21) | ❌ Not supported (falls back to synchronous execution) | -> **Cross-language async limitation**: When using cross-language resources (e.g., calling Java integrations from Python or vice versa), async execution is not supported. Cross-language calls always execute synchronously regardless of your JDK version. - This is important because: - **For Python users**: Async execution is always available. -- **For Java users on JDK 21+**: Async execution is available, so using native integrations (instead of cross-language) matters for performance. -- **For Java users on JDK < 21**: Async execution is **not available regardless of whether you use native or cross-language integrations**. Therefore, the cross-language async limitation has **no additional performance impact** for these users. +- **For Java users on JDK 21+**: Async execution is available. +- **For Java users on JDK < 21**: Async execution is not available and falls back to synchronous execution. ### Native Integration Support Matrix -Flink Agents provides built-in integrations for many ecosystem providers. Some integrations are only available in one language. For those marked as ❌, you can still use them from the other language via cross-language support, but cross-language calls do not support async execution. +Flink Agents provides built-in integrations for many ecosystem providers. Some integrations are only available in one language. For those marked as ❌, you can still use them from the other language via cross-language support. Review Comment: Nit: this depends on the Flink version — cross-language async needs the pemja 0.6.2 fix (Flink 1.20.5+ / 2.0.2+ / 2.1.3+ / 2.2.1+), and we currently build against 2.2.0, so these calls still run synchronously for now. Once we move to a Flink build with the fix (1.20.5 is being voted on upstream now), it'll hold. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
