snuyanzin commented on code in PR #27026:
URL: https://github.com/apache/flink/pull/27026#discussion_r3303146559
##########
flink-filesystems/flink-s3-fs-hadoop/pom.xml:
##########
@@ -84,12 +84,35 @@ under the License.
<scope>test</scope>
</dependency>
- <!-- S3 base -->
+ <!-- S3 base - exclude AWS SDK v1 -->
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-s3-fs-base</artifactId>
<version>${project.version}</version>
<optional>${flink.markBundledAsOptional}</optional>
+ <exclusions>
+ <!-- Exclude all AWS SDK v1 dependencies - we
use SDK v2 -->
+ <exclusion>
Review Comment:
Can you clarify on this: why do we exclude all v1 dependencies if here you
say we still need it
https://github.com/apache/flink/pull/27026#discussion_r3283482576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
