PavelZeger commented on PR #1115: URL: https://github.com/apache/flink-kubernetes-operator/pull/1115#issuecomment-4524806157
> The typo fix is correct, however there are some things to be fixed in this PR: > > 1. **The import reordering violates the project's Spotless config** - The PR puts `static java.util.Objects.requireNonNull` at the top and collapses the group separators. `mvn spotless:check` will fail. Please revert the import blocks on all three copies and run `mvn spotless:apply` before pushing. > 2. **Local verification was skipped** - Step 3 of the Flink contribution guide (https://flink.apache.org/how-to-contribute/contribute-code/#3-open-a-pull-request) requires running build and style checks locally. `mvn spotless:check` is the exact command this PR fails on. Please make sure both `mvn spotless:check` and `mvn checkstyle:check` pass before re-requesting review. > 3. **Wrong formatted PR description** - The standard Flink Operator template sections are present but the markdown headers were stripped and the content collapsed into prose. If an AI assistant helped draft the description, please paste the output verbatim with the formatting intact and give it a proofread before submitting, as the loss of structure is fairly visible. The "Verifying this change" section should also state explicitly that `mvn spotless:check` and the tests passed locally. Thanks for the review @Dennis-Mircea . Required fixes for changed files were addressed. Please pay attention that local `mvn spotless:check` failed on the error in another file: ```txt [ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.40.0:check (default-cli) on project flink-kubernetes-webhook: Unable to format file /Users/pavelzeger/Projects/open-source/flink/fork/flink-kubernetes-operator/flink-kubernetes-webhook/src/test/java/org/apache/flink/kubernetes/operator/admission/FlinkOperatorWebhookTest.java: com.google.googlejavaformat.java.FormatterException: 466:49: error: ')' expected -> [Help 1] ``` The PR's format will be updated as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
