snuyanzin commented on code in PR #28152:
URL: https://github.com/apache/flink/pull/28152#discussion_r3272111506
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactoryImpl.java:
##########
@@ -563,8 +563,7 @@ private RelDataType decimalOf2(RelDataType type) {
return createSqlType(SqlTypeName.DECIMAL, 38, 0);
case REAL:
return createSqlType(SqlTypeName.DECIMAL, 14, 7);
- case FLOAT:
- return createSqlType(SqlTypeName.DECIMAL, 14, 7);
+ case FLOAT: // sic
Review Comment:
so far (in 1..37.0) it doesn't have.
More will come with 1.38.0 when java's `Double` will be used for
`FLOAT`/`REAL`/`DOUBLE` to proper support `NaN`/`+Infinity`/`-Infinity`
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactoryImpl.java:
##########
@@ -563,8 +563,7 @@ private RelDataType decimalOf2(RelDataType type) {
return createSqlType(SqlTypeName.DECIMAL, 38, 0);
case REAL:
return createSqlType(SqlTypeName.DECIMAL, 14, 7);
- case FLOAT:
- return createSqlType(SqlTypeName.DECIMAL, 14, 7);
+ case FLOAT: // sic
Review Comment:
so far (in 1.37.0) it doesn't have.
More will come with 1.38.0 when java's `Double` will be used for
`FLOAT`/`REAL`/`DOUBLE` to proper support `NaN`/`+Infinity`/`-Infinity`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
