wenjin272 commented on PR #599:
URL: https://github.com/apache/flink-agents/pull/599#issuecomment-4484254934
Hi, @JinkunLiu @xintongsong , I pushed 3 commits to address the remaining
review comments. PTAL.
- **e8f9c0ea** — Adds an 85-test bats-core suite under `tools/test/` (unit
+ PATH-shim integration, including an exact-argv pin on `download_file` as a
regression guard for the `--` bug) plus a CI job running on Ubuntu and macOS.
- **525adad5** — `pip_install_quiet` helper replaces noisy `pip install`
output with a single rolling status line on tty (full log surfaced on failure),
`gum spin` when gum is available, and `--quiet` in CI.
- **54ccd1b9** — Confirm prompt is now Proceed / Edit a setting / Cancel;
the Edit submenu re-prompts any currently-applicable field (Flink Yes/No,
version, install dir, FLINK_HOME, PyFlink Yes/No, venv dir) and re-displays the
plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
