Samrat002 commented on code in PR #28136:
URL: https://github.com/apache/flink/pull/28136#discussion_r3258988479


##########
flink-filesystems/flink-s3-fs-native/pom.xml:
##########
@@ -89,6 +89,18 @@ under the License.
                        <optional>${flink.markBundledAsOptional}</optional>
                </dependency>
 
+               <!--
+                       AWS CRT HTTP client (compile-only; NOT bundled in fat 
JAR due to JNI shading constraints).
+                       Users who enable s3.crt.enabled must place 
aws-crt-client and aws-crt JARs
+                       in the Flink plugin directory alongside 
flink-s3-fs-native.jar.
+               -->

Review Comment:
   added 



##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -292,6 +292,27 @@ public class NativeS3FileSystemFactory implements 
FileSystemFactory {
                                     + "When not set, the default chain is 
used: delegation tokens -> "
                                     + "static credentials (if configured) -> 
DefaultCredentialsProvider.");
 
+    public static final ConfigOption<Boolean> CRT_ENABLED =
+            ConfigOptions.key("s3.crt.enabled")
+                    .booleanType()
+                    .defaultValue(false)
+                    .withDescription(
+                            "Enable AWS Common Runtime (CRT) HTTP transport. "
+                                    + "When true, uses AwsCrtHttpClient for 
sync S3 operations and "
+                                    + "S3AsyncClient.crtBuilder() for 
async/transfer operations, "
+                                    + "providing higher throughput for large 
S3 transfers. "
+                                    + "Requires aws-crt-client and aws-crt 
JARs in the plugin directory "
+                                    + "(they are not bundled in the fat JAR 
due to JNI shading constraints).");
+
+    public static final ConfigOption<Double> CRT_TARGET_THROUGHPUT_GBPS =

Review Comment:
   soft limit . added in readme doc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to