weiqingy commented on code in PR #667: URL: https://github.com/apache/flink-agents/pull/667#discussion_r3251710604
########## runtime/src/main/java/org/apache/flink/agents/runtime/operator/DurableExecutionManager.java: ########## Review Comment: Thanks for catching this, @wenjin272. Confirmed it's dead code on `main` today, but it predates this PR — not a conflict-resolution loss. Timeline from `git log -S "maybePruneState"`: 1. **#138** introduced `private void maybePruneState(...)` on `ActionExecutionOperator`, called from the per-key completion path: `maybePruneState(key, sequenceNumber);`. 2. **#603 "Fix prune state corner cases around checkpoints"** *deliberately* removed both the call site and the helper. The fix moved pruning from the per-key path to the checkpoint-driven path inside `notifyCheckpointComplete`, where it now prunes using `lastCompletedSequenceNumber` captured at the checkpoint barrier (via `snapshotLastCompletedSequenceNumbers`). That's the current/correct architecture. 3. **#546 "Refactor ActionExecutionOperator into focused manager classes"** extracted `DurableExecutionManager` and re-surfaced `maybePruneState(...)` as a package-private method on the new class — but no caller was re-added (correctly, since #603 eliminated that path). This is the orphan. This seems to be leftover from the #546 refactor. This PR didn’t touch this method. Since the CI for this PR has already passed, and considering that the CI checks are not fully stable, I created a separate PR to fix it: https://github.com/apache/flink-agents/pull/682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
