spuru9 commented on code in PR #28154:
URL: https://github.com/apache/flink/pull/28154#discussion_r3236085513
##########
flink-models/flink-model-triton/pom.xml:
##########
@@ -34,10 +34,21 @@ under the License.
<properties>
<okhttp.version>4.12.0</okhttp.version>
- <jackson.version>2.15.2</jackson.version>
<test.gson.version>2.11.0</test.gson.version>
</properties>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
+ <version>${jackson-bom.version}</version>
Review Comment:
Good catch — confirmed both points: the root pom imports `jackson-bom` at
lines 644-649 (FLINK-39580), and `flink-models/pom.xml` adds no own
`<dependencyManagement>`, so child modules already inherit the BOM. Removed the
redundant block in `a1e2a72b62b`. `mvn -pl flink-models/flink-model-triton
dependency:resolve` still reports `jackson-core` / `jackson-databind` 2.21.3
and `jackson-annotations` 2.21, same as before. Thanks.
##########
flink-models/flink-model-triton/pom.xml:
##########
@@ -34,10 +34,21 @@ under the License.
<properties>
<okhttp.version>4.12.0</okhttp.version>
- <jackson.version>2.15.2</jackson.version>
<test.gson.version>2.11.0</test.gson.version>
</properties>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
+ <version>${jackson-bom.version}</version>
Review Comment:
Thanks @featzhang, have made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
