Dennis-Mircea commented on code in PR #28023:
URL: https://github.com/apache/flink/pull/28023#discussion_r3233985391
##########
flink-tests/pom.xml:
##########
@@ -90,12 +90,6 @@ under the License.
<type>test-jar</type>
</dependency>
- <dependency>
Review Comment:
Good catch, and yes, `flink-tests` has no `src/main`, so semantically
`<scope>test</scope>` would be the more accurate scope. I deliberately kept the
unscoped one for a different reason: when Maven sees a duplicated dependency,
the last declaration wins (with a warning). In the pre-fix POM the unscoped
entry was at line ~220, after the test-scoped entry at line ~96, so the
effective scope on master today is already compile. Dropping the first
(test-scoped) entry preserves the existing effective build behavior, which
keeps this commit a true no-op cleanup as the `[hotfix]` prefix advertises.
Tightening the scope to test is a separate semantic question. I'm ok to do
it here if you prefer, or leave it as a follow-up so this PR stays purely a
duplicate-removal.
##########
flink-tests/pom.xml:
##########
@@ -427,6 +421,19 @@ under the License.
</sources>
</configuration>
</execution>
+ <!-- Add generated Avro test sources to
build path -->
Review Comment:
It is part of the duplicate removal, the duplicated entry here is a
`<plugin>` rather than a `<dependency>`. Pre-fix, `flink-tests/pom.xml`
declared `org.codehaus.mojo:build-helper-maven-plugin` twice in
`<build><plugins>`. The second declaration existed solely to host the
`add-avro-test-source` execution.
To remove the duplicate `<plugin>` block without dropping that execution, I
moved the `add-avro-test-source` execution into the `<executions>` of the first
(surviving) `build-helper-maven-plugin` block. Net effect: one plugin
declaration, same set of executions, no behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
