[ https://issues.apache.org/jira/browse/FLINK-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834452#comment-15834452 ]
ASF GitHub Bot commented on FLINK-5214: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3178#discussion_r97313842 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java --- @@ -342,21 +343,50 @@ public final OperatorSnapshotResult snapshotState( StateSnapshotContextSynchronousImpl snapshotContext = new StateSnapshotContextSynchronousImpl( checkpointId, timestamp, streamFactory, keyGroupRange, getContainingTask().getCancelables()); - snapshotState(snapshotContext); + try { --- End diff -- Yes, you're right. Will refactor the code that way :-) > Clean up checkpoint files when failing checkpoint operation on TM > ----------------------------------------------------------------- > > Key: FLINK-5214 > URL: https://issues.apache.org/jira/browse/FLINK-5214 > Project: Flink > Issue Type: Bug > Components: TaskManager > Affects Versions: 1.2.0, 1.1.3 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Fix For: 1.2.0, 1.1.4 > > > When the {{StreamTask#performCheckpoint}} operation fails on a > {{TaskManager}} potentially created checkpoint files are not cleaned up. This > should be changed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)