Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3182#discussion_r97282806
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java
 ---
    @@ -212,6 +206,19 @@ public ExecutionJobVertex(
                finishedSubtasks = new boolean[parallelism];
        }
     
    +   public void setMaxParallelismDerived(int maxParallelism) {
    +
    +           Preconditions.checkState(VALUE_NOT_SET == 
maxParallelismConfigured,
    +                           "Attempt to override a configured max 
parallelism. Configured: " + maxParallelismConfigured
    +                                           + ", argument: " + 
maxParallelism);
    +
    +           Preconditions.checkArgument(maxParallelism > 0
    +                                           && maxParallelism <= 
KeyGroupRangeAssignment.UPPER_BOUND_MAX_PARALLELISM,
    +                           "Overriding max parallelism is not in valid 
bounds: " + maxParallelism);
    --- End diff --
    
    Maybe we could add the valid bounds here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to