Github user uce commented on the issue:
https://github.com/apache/flink/pull/3117
Thanks for addressing the comments.
I had a quick offline chat with Stephan regarding the naming of
`setAdditionalNodeHash`. He also agrees that the name moves internal
implementation details to the user API. Furthermore he raised the point that
there is no way for the user to get the relation between `uid` and
`setAdditionalNodeHash`.
He proposed the following, which I liked.
- Rename `setAdditionalNodeHash` to `setUidHash`. Add a big fat comment
that this should be used as a work around or for trouble shooting.
- Add a comment to `uid` saying that the given String will be hashed to the
ID that corresponds to the JobVertexID in the logs/web UI so users now what's
happening.
- Make in both Javadocs clear how the methods relate to eachother.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
